loopd: nil-pointer bug when showing subsystems #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
reviewed
Mar 24, 2023
| @@ -204,6 +197,13 @@ func Run(rpcCfg RPCConfig) error { | |||
| logWriter := build.NewRotatingLogWriter() | |||
| SetupLoggers(logWriter, shutdownInterceptor) | |||
|
|
|||
| // Special show command to list supported subsystems and exit. | |||
| if config.DebugLevel == "show" { | |||
There was a problem hiding this comment.
Is this fix effective because if err := Validate(&config) precedes now?
There was a problem hiding this comment.
hmm let me check
There was a problem hiding this comment.
yeah so debuglevel validation seems not part and not necessary to validate so it should be fixed, but maybe we clean this code part up a bit, maybe just get rid of the global pointer variable which led to the bug in the first place and do a clean initialization ?
hieblmi
force-pushed
the
bugfix-nil-pointer
branch
from
172c076 to
0cbaeaa
Compare
hieblmi
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Rebased this PR and tested, as @ziggie1984 mentioned the validation doesn't check the debuglevel, so moving the code is fine. LGTM 💾
✅ tAck
hieblmi
force-pushed
the
bugfix-nil-pointer
branch
from
0cbaeaa to
a853b17
Compare
hieblmi
force-pushed
the
bugfix-nil-pointer
branch
from
dcd4367 to
5db270d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a short drive-bug fix: loopd crashes when you wanna show the logging subsystems with
loopd --debuglevel showThis fix just copies the rogue code to another place, but I think a better fix would be to get rid of the global pointer and maybe just return the logger when setting it up ?
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes